D29709: Give all OverlaySheets consistent headers

Nathaniel Graham noreply at phabricator.kde.org
Wed May 13 14:19:44 BST 2020


ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  OverlaySheet has a `header:` property typically used to give the sheet a title. This patch
  used it to give all of Discover's OverlaySheets appropriate titles. The review sheet's
  top layout is slightly adjusted to make this look good.

TEST PLAN
  F8316475: Screenshot_20200513_070836.png <https://phabricator.kde.org/F8316475>
  F8316512: Screenshot_20200513_071510.png <https://phabricator.kde.org/F8316512>

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29709

AFFECTED FILES
  discover/qml/AddonsView.qml
  discover/qml/ApplicationPage.qml
  discover/qml/DiscoverWindow.qml
  discover/qml/ReviewsPage.qml
  discover/qml/SourcesPage.qml
  discover/qml/UpdatesPage.qml

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200513/2afb282c/attachment-0001.htm>


More information about the Plasma-devel mailing list