D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent
Jiří Paleček
noreply at phabricator.kde.org
Mon May 11 17:45:35 BST 2020
jpalecek updated this revision to Diff 82568.
jpalecek added a comment.
Move the client deregistering code from SensorBrowserModel to HostInfo
Also remove the clear function. After investigating further, I've
found out it suffers from the same problem, that it doesn't deregister
from the hosts it removes. On top of that, it leaves dangling pointers
in mSensorInfoMap. It doesn't really clear all the other internal
structures. And it is never used. So I think it's best to delete it.
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29616?vs=82486&id=82568
REVISION DETAIL
https://phabricator.kde.org/D29616
AFFECTED FILES
gui/SensorBrowser.cpp
gui/SensorBrowser.h
gui/ksysguard.cpp
gui/ksysguard.h
To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200511/7c5e33fb/attachment.htm>
More information about the Plasma-devel
mailing list