D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

Jiří Paleček noreply at phabricator.kde.org
Mon May 11 15:40:21 BST 2020


jpalecek added inline comments.

INLINE COMMENTS

> ahiemstra wrote in SensorBrowser.cpp:53
> I agree with Anthony though, if you delete a hostInfo it _should_ remove its connection. So it's better to move this code into a destructor for HostInfo.

But the host info, at least in its present form, doesn't have the client pointer to pass to `disconnectClient`. But I can see your point, I will change it.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29616

To: jpalecek, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200511/b395ef47/attachment.htm>


More information about the Plasma-devel mailing list