D28154: Add users KCM
David Edmundson
noreply at phabricator.kde.org
Thu May 7 15:59:32 BST 2020
davidedmundson added inline comments.
INLINE COMMENTS
> cblack wrote in kcm.cpp:121
> that looks like it could possibly run into race conditions, as the applyjob is executed asynchronously and IIRC is able to still be running when everything else, including this, has destructed and removed one of the files it could be using
new QTemporaryFile(qApp) then
KJobs have an QEventLoopLocker that will stop qApp from quitting until they finish so you can be sure your applyjob is done.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D28154
REVISION DETAIL
https://phabricator.kde.org/D28154
To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200507/a3f348d0/attachment.htm>
More information about the Plasma-devel
mailing list