D28154: Add users KCM

Carson Black noreply at phabricator.kde.org
Thu May 7 15:57:31 BST 2020


cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:121
> Normally the app creating a temp file would clean it up.
> 
> A quick fix would be
> file = new QTemporaryFile(this);
> 
> It's sort of leaking the object, but on exit it'll tidy everything up.

that looks like it could possibly run into race conditions, as the applyjob is executed asynchronously and IIRC is able to still be running when everything else, including this, has destructed and removed one of the files it could be using

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200507/d6e28a91/attachment-0001.htm>


More information about the Plasma-devel mailing list