D29264: New tabs for Breeze

[Nathaniel Graham]

ngraham added a comment.


  In general I think this is a good direction to move in. However I don't think it's quite ready yet.
  
  Small nitpick: this will result in framed tab views having rounded bottom corners, but at least one pointy top corner: F8284555: Screenshot_20200504_140532.png <https://phabricator.kde.org/F8284555>
  
  That should be easily fixable though.
  
  I think the blue line on top is an improvement and brings the tabs closer to the Plasma appearance, which is desirable from a #consistency <https://phabricator.kde.org/tag/goal_consistency/> point of view. However I'm finding that the current tab just doesn't look distinct enough from un-focused tabs anymore. I would suggest to re-add the darkened background for inactive tabs, but then we run into T13054: Unify how Breeze communicates checked/current/selected states <https://phabricator.kde.org/T13054>. Using only color to communicate the "current tab" state would jive with that, but then I start to think that we don't have //enough// color here and that it should look more like a Plasma tab, with a thicker highlight bar and the whole background colored. But then if we do that, we're fully abandoning @cblack's idea to make tab appearance dependent on the type of view (editable/document vs non-editable/tool view).
  
  Bottom line, I think we need to discuss what we really want here before we move forward with implementation anymore, to avoid wasting your time!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200504/481fab58/attachment.html>