D29356: [applets/systemtray] Fix value read in some onXyxChanged connections
Konrad Materka
noreply at phabricator.kde.org
Sat May 2 10:16:15 BST 2020
kmaterka added a comment.
Fix exctracted from D29344 <https://phabricator.kde.org/D29344>, to make things clear - one commit, one change.
INLINE COMMENTS
> main.qml:81
> target: plasmoid
> - function onUserConfiguringChanged(userConfiguring) {
> - if (userConfiguring) {
> + function onUserConfiguringChanged() {
> + if (plasmoid.userConfiguring) {
`Plasma::Applet::userConfiguringChanged` sends value, but `Plasma::AppletInterface::userConfiguringChanged` does not (signal has no parameters).
> main.qml:91
>
> - function onExtraItemsChanged(extraItems) {
> - plasmoid.nativeInterface.allowedPlasmoids = extraItems
> + function onExtraItemsChanged() {
> + plasmoid.nativeInterface.allowedPlasmoids = plasmoid.configuration.extraItems
I'm pretty sure this worked before... Maybe something changed in `QQmlPropertyMap` in Qt 5.14?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29356
To: kmaterka, #plasma_workspaces, #plasma, ngraham, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200502/225cb78e/attachment-0001.html>
More information about the Plasma-devel
mailing list