<table><tr><td style="">kmaterka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29356">View Revision</a></tr></table><br /><div><div><p>Fix exctracted from <a href="https://phabricator.kde.org/D29344" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D29344</a>, to make things clear - one commit, one change.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29356#inline-167883">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:81</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">target:</span> <span style="color: #004012">plasmoid</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">function</span> <span style="color: #004012">onUserConfiguringChanged</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">userConfiguring</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">userConfiguring</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">function</span> <span style="color: #004012">onUserConfiguringChanged</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">plasmoid</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span style="color: #004012">userConfiguring</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">Plasma::Applet::userConfiguringChanged</tt> sends value, but <tt style="background: #ebebeb; font-size: 13px;">Plasma::AppletInterface::userConfiguringChanged</tt> does not (signal has no parameters).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29356#inline-167880">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:91</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">function</span> <span style="color: #004012">onExtraItemsChanged</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">extraItems</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">nativeInterface</span><span class="p">.</span><span style="color: #004012">allowedPlasmoids</span> <span style="color: #aa2211">=</span> <span style="color: #004012">extraItems</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">function</span> <span style="color: #004012">onExtraItemsChanged</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">nativeInterface</span><span class="p">.</span><span style="color: #004012">allowedPlasmoids</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #004012"><span class="bright">plasmoid</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">configuration</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span style="color: #004012">extraItems</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm pretty sure this worked before... Maybe something changed in <tt style="background: #ebebeb; font-size: 13px;">QQmlPropertyMap</tt> in Qt 5.14?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29356">https://phabricator.kde.org/D29356</a></div></div><br /><div><strong>To: </strong>kmaterka, Plasma: Workspaces, Plasma, ngraham, apol<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>