D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex added a comment.


  In D28439#638357 <https://phabricator.kde.org/D28439#638357>, @bruns wrote:
  
  > In D28439#638188 <https://phabricator.kde.org/D28439#638188>, @davidedmundson wrote:
  >
  > > QIcon isn't thread safe.
  >
  >
  > I think this is related to https://phabricator.kde.org/D5889?id=14601 ?
  >
  > I think we are save here, as the QIcon is created from an image stored on disk (absolute path to e.g. PNG), not from a theme.
  
  
  Thanks for the response, I was not sure if QIcon being not thread safe was meant in general or only for QIcon::fromTheme.
  
  PS: When I said docs I meant the QIcon class docs, but thanks 😃

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200330/cfa8300f/attachment.html>