D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Stefan Brüns]

bruns added a comment.


  In D28439#638188 <https://phabricator.kde.org/D28439#638188>, @davidedmundson wrote:
  
  > QIcon isn't thread safe.
  
  
  I think this is related to https://phabricator.kde.org/D5889?id=14601 ?
  
  I think we are save here, as the QIcon is created from an image stored on disk (absolute path to e.g. PNG), not from a theme.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200330/f83a5eba/attachment.html>