D28275: skip over supposed network shares that aren't
Harald Sitter
noreply at phabricator.kde.org
Wed Mar 25 11:13:28 GMT 2020
sitter created this revision.
sitter added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
we explicitly request listFromType(Solid::DeviceInterface::NetworkShare)
but apparently still can get devices that aren't actually of that type.
add an explicit type check to guard against bogus shares coming out of
listFromType.
CCBUG: 419220
TEST PLAN
mount an overlay (I am guessing that's what the problem with kubuntu is), observe no crash on init
REPOSITORY
R102 KInfoCenter
BRANCH
smb-type-check
REVISION DETAIL
https://phabricator.kde.org/D28275
AFFECTED FILES
Modules/samba/smbmountmodel.cpp
To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200325/417b3329/attachment.html>
More information about the Plasma-devel
mailing list