D28222: Add ShadowedImage and ShadowedTexture items

Arjen Hiemstra noreply at phabricator.kde.org
Mon Mar 23 16:47:23 GMT 2020


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds the ShadowedImage and ShadowedTexture items. The first is a
  QML-only item that makes use of the second. The second is a 
  ShadowedRectangle that uses a texture as color source for the item
  instead of just a color.
  
  It also does some cleanup on the scenegraph/shader related bits
  introduced with ShadowedRectangle. Most importantly, it removes the
  mostly duplicated core shaders in favour of a simple solution using
  a #define.

TEST PLAN
  There's a manual test included. It should look like this:

REPOSITORY
  R169 Kirigami

BRANCH
  shadowed_texture

REVISION DETAIL
  https://phabricator.kde.org/D28222

AFFECTED FILES
  kirigami.qrc
  src/CMakeLists.txt
  src/controls/ShadowedImage.qml
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shaders/header_desktop.glsl
  src/scenegraph/shaders/header_desktop_core.glsl
  src/scenegraph/shaders/header_es.glsl
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shaders/shaders.qrc
  src/scenegraph/shaders/shadowedborderrectangle.frag
  src/scenegraph/shaders/shadowedbordertexture.frag
  src/scenegraph/shaders/shadowedrectangle.frag
  src/scenegraph/shaders/shadowedrectangle.vert
  src/scenegraph/shaders/shadowedtexture.frag
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedborderrectanglematerial.cpp
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedbordertexturematerial.h
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/scenegraph/shadowedtexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.h
  src/scenegraph/shadowedtexturenode.cpp
  src/scenegraph/shadowedtexturenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  src/shadowedtexture.cpp
  src/shadowedtexture.h
  tests/ShadowedImageTest.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200323/4b124e20/attachment.html>


More information about the Plasma-devel mailing list