<table><tr><td style="">ahiemstra created this revision.<br />ahiemstra added a reviewer: Kirigami.<br />Herald added a project: Kirigami.<br />Herald added a subscriber: plasma-devel.<br />ahiemstra requested review of this revision.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28222">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This adds the ShadowedImage and ShadowedTexture items. The first is a<br />

QML-only item that makes use of the second. The second is a <br />

ShadowedRectangle that uses a texture as color source for the item<br />

instead of just a color.</p>

<p>It also does some cleanup on the scenegraph/shader related bits<br />

introduced with ShadowedRectangle. Most importantly, it removes the<br />

mostly duplicated core shaders in favour of a simple solution using<br />

a #define.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>There's a manual test included. It should look like this:</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>BRANCH</strong><div><div>shadowed_texture</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28222">https://phabricator.kde.org/D28222</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kirigami.qrc<br />

src/CMakeLists.txt<br />

src/controls/ShadowedImage.qml<br />

src/kirigamiplugin.cpp<br />

src/scenegraph/header_desktop.glsl<br />

src/scenegraph/header_desktop_core.glsl<br />

src/scenegraph/header_es.glsl<br />

src/scenegraph/shaders.qrc<br />

src/scenegraph/shaders/header_desktop.glsl<br />

src/scenegraph/shaders/header_desktop_core.glsl<br />

src/scenegraph/shaders/header_es.glsl<br />

src/scenegraph/shaders/sdf.glsl<br />

src/scenegraph/shaders/shaders.qrc<br />

src/scenegraph/shaders/shadowedborderrectangle.frag<br />

src/scenegraph/shaders/shadowedbordertexture.frag<br />

src/scenegraph/shaders/shadowedrectangle.frag<br />

src/scenegraph/shaders/shadowedrectangle.vert<br />

src/scenegraph/shaders/shadowedtexture.frag<br />

src/scenegraph/shadowedborderrectangle.frag<br />

src/scenegraph/shadowedborderrectangle_core.frag<br />

src/scenegraph/shadowedborderrectanglematerial.cpp<br />

src/scenegraph/shadowedbordertexturematerial.cpp<br />

src/scenegraph/shadowedbordertexturematerial.h<br />

src/scenegraph/shadowedrectangle.frag<br />

src/scenegraph/shadowedrectangle.vert<br />

src/scenegraph/shadowedrectangle_core.frag<br />

src/scenegraph/shadowedrectangle_core.vert<br />

src/scenegraph/shadowedrectanglematerial.cpp<br />

src/scenegraph/shadowedrectanglenode.cpp<br />

src/scenegraph/shadowedrectanglenode.h<br />

src/scenegraph/shadowedtexturematerial.cpp<br />

src/scenegraph/shadowedtexturematerial.h<br />

src/scenegraph/shadowedtexturenode.cpp<br />

src/scenegraph/shadowedtexturenode.h<br />

src/shadowedrectangle.cpp<br />

src/shadowedrectangle.h<br />

src/shadowedtexture.cpp<br />

src/shadowedtexture.h<br />

tests/ShadowedImageTest.qml</div></div></div><br /><div><strong>To: </strong>ahiemstra, Kirigami<br /><strong>Cc: </strong>plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart<br /></div>