D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching
Alexander Lohnau
noreply at phabricator.kde.org
Sun Mar 22 07:37:22 GMT 2020
alex created this revision.
alex added reviewers: bruns, z3ntu, apol, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
Before this patch the path to the default profile database was once read and then written in the config. And as long as this file exists this value would be used. But if the user changes the default profile in Firefox the old profile will still be used (as long as it is not deleted).
And the default profile was also not always correctly extracted (this configuration got only edited in the about:profiles page in Firefox):
F8192502: BugfixDoc <https://phabricator.kde.org/F8192502>
TEST PLAN
Test if the bookmarks are correctly displayed (with a single profile), add a new profile and restart KRunner, set the default profile back to the old profile and restart KRunner.
The bookmarks should always be displayed.
REPOSITORY
R120 Plasma Workspace
BRANCH
bookmarks_firefox_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28196
AFFECTED FILES
runners/bookmarks/browsers/firefox.cpp
To: alex, bruns, z3ntu, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200322/dcc3cfe7/attachment-0001.html>
More information about the Plasma-devel
mailing list