D28138: some static analyzer improvements for service runner

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  - be more consty (and don't risk detatching containers)
  - init members
  - don't ql1s to qstring
  - use auto when newing an object

TEST PLAN
  test passes

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28138

AFFECTED FILES
  runners/services/autotests/servicerunnertest.cpp
  runners/services/servicerunner.cpp
  runners/services/servicerunner.h

To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200319/b8dbdd05/attachment.html>