<table><tr><td style="">sitter created this revision.<br />sitter added a reviewer: broulik.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28138">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">be more consty (and don't risk detatching containers)</li>
<li class="remarkup-list-item">init members</li>
<li class="remarkup-list-item">don't ql1s to qstring</li>
<li class="remarkup-list-item">use auto when newing an object</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>test passes</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28138">https://phabricator.kde.org/D28138</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>runners/services/autotests/servicerunnertest.cpp<br />
runners/services/servicerunner.cpp<br />
runners/services/servicerunner.h</div></div></div><br /><div><strong>To: </strong>sitter, broulik<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>