D28107: Fix overlayIcon sometimes not visible

[Konrad Materka]

kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  Yep, icons in SNI are a mess...
  Icons are processed in `StatusNotifierItemSource`, including overlay - that's were this should be fixed. From you comment I see it won't be easy...
  This is a workaround, it works, but makes the code even more messy.
  
  So... if you are brave enough, you can rewrite icon handling in SNI. Idea is to:
  
  - remove custom icon handling code from `StatusNotifierItemSource`
  - pass data directly to QML
  - move icon display logic to QML
  
  What do you think?

INLINE COMMENTS

> systemtraymodel.cpp:321
> +         */
> +        if(!icon.value<QIcon>().name().isEmpty()) {
> +            updateItemData(dataItem, data, Role::OverlayIconName);

code formatting (missing space after if)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28107

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200317/49dc3308/attachment-0001.html>