<table><tr><td style="">kmaterka requested changes to this revision.<br />kmaterka added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28107">View Revision</a></tr></table><br /><div><div><p>Yep, icons in SNI are a mess...<br />
Icons are processed in <tt style="background: #ebebeb; font-size: 13px;">StatusNotifierItemSource</tt>, including overlay - that's were this should be fixed. From you comment I see it won't be easy...<br />
This is a workaround, it works, but makes the code even more messy.</p>
<p>So... if you are brave enough, you can rewrite icon handling in SNI. Idea is to:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">remove custom icon handling code from <tt style="background: #ebebeb; font-size: 13px;">StatusNotifierItemSource</tt></li>
<li class="remarkup-list-item">pass data directly to QML</li>
<li class="remarkup-list-item">move icon display logic to QML</li>
</ul>
<p>What do you think?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28107#inline-159359">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemtraymodel.cpp:321</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">icon</span><span class="p">.</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QIcon</span><span style="color: #aa2211">></span><span class="p">().</span><span class="n">name</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">updateItemData</span><span class="p">(</span><span class="n">dataItem</span><span class="p">,</span> <span class="n">data</span><span class="p">,</span> <span class="n">Role</span><span style="color: #aa2211">::</span><span class="n">OverlayIconName</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">code formatting (missing space after if)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28107">https://phabricator.kde.org/D28107</a></div></div><br /><div><strong>To: </strong>davidre, kmaterka, Plasma, broulik, davidedmundson<br /><strong>Cc: </strong>anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>