D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:4382
> I am sorry to say this is a serious show stopper. 
> One cannot reset/update the kiconloader palette at every repaint event for every single toolbutton in toolbars especially when there are animations (not only for the active inactive switch but also simply mouse-over).
> 
> If there is no way to make this more efficient, then as far as I am concerned this is a no-go.
> 
> Maybe one could try to cache the icons ourselves ? (and trigger cache clear when appropriate ?)

I'll dig in KIconLoader code a bit over the week-end to see what really happens when calling setCustomPalette and resetPalette, to get a sense of how resource consuming this is ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200313/a9bf89d0/attachment-0001.html>