D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:4382
> Not at every paint event. You should check if kiconloader already have a customPalette, if it matches the one you want, and update (or reset) only when necessary.

The issue is that the QStyle only has the global icon palette to mutate for the tools area.  If the custom palette were to be left intact, that would affect widgets it's not supposed to. There is no other code flow that won't result in KIconLoader using a custom palette when it shouldn't.

The reason this is necessary in the first place is that KIconLoader doesn't honor the widget palettes set elsewhere in the QStyle. This code is simply working with what it's being given, and the issues that lead to this solution are deep-rooted in Qt. You simply cannot do anything else without likely breaking Qt's current APIs that are in control of this.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200312/42345a2d/attachment-0001.html>