D27979: [WIP] Add top area to notifications

Nathaniel Graham noreply at phabricator.kde.org
Wed Mar 11 15:24:59 GMT 2020


ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Please test to make sure that your patches work :)

INLINE COMMENTS

> NotificationItem.qml:114
>  
> -    NotificationHeader {
> -        id: notificationHeading
> -        Layout.fillWidth: true
> +    PlasmaExtraComponents.PlasmoidHeading {
> +        bottomInset: Math.round(thumbnailTopPadding / 2)

there's no such thing as `PlasmaExtraComponents`

> NotificationItem.qml:119
>          Layout.rightMargin: notificationItem.headingRightPadding
> +        
> +        NotificationHeader {

there are spaces on this line

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200311/97afba98/attachment.html>


More information about the Plasma-devel mailing list