D27979: Added top area to notifications

[Kai Uwe Broulik]

broulik added a comment.


  Please also test with icons and configure button, I use https://tests.peter.sh/notification-generator/ which can generate a multitude of test notifications

INLINE COMMENTS

> NotificationPopup.qml:168
>                  // let the item bleed into the dialog margins so the close button margins cancel out
> -                y: closable || dismissable || configurable ? -notificationPopup.margins.top : 0
> +                y: closable || dismissable || configurable ? -math.round(notificationPopup.margins.top / 2) : 0
>                  headingRightPadding: -notificationPopup.margins.right

You know I'm not a fan of randomly dividing sizes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200311/10739da7/attachment-0001.html>