D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  In D27669#625187 <https://phabricator.kde.org/D27669#625187>, @davidre wrote:
  
  > Again why are we introducing this separator line and even drawing it under normal titlebars? Compared to before
  >  F8168549: grafik.png <https://phabricator.kde.org/F8168549>
  
  
  As a part of T11661: Replace framed views with single-pixel separator lines <https://phabricator.kde.org/T11661>. The general idea is to move away from using framed views and instead use single-pixel lines to separate logical window regions (e.g tools area on top, sidebar on left, main content view on right, etc).
  
  The extra line is designed to look good when both the Tools Area and the window background color are gray, but different shades of it. So I would agree with you that it is indeed unnecessary when the Tools Area's color is similar or identical to the line's color, or strongly different from the window background color--i.e. as in the current default Breeze color scheme. I'd be okay not drawing it in this case.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200310/0e1f5faf/attachment.html>