D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  In D27808#625052 <https://phabricator.kde.org/D27808#625052>, @meven wrote:
  
  > Porting with such feature regression is hard to justify.
  
  
  I honestly don't know how many users actually use that feature; if it's still widely used, then yeah, that would definitely be a feature regression.
  
  > Perhaps we should port KFontDialog (it is ~150 lines of cpp) to kwidgetsaddons instead, `KFontChooser` is already there.
  >  Or better perhaps implement here a simple QDialog embedding `KFontChooser` and providing equivalent features needed here that KFontDialog has.
  >  This is a typical work we did for KF5 https://community.kde.org/Frameworks/Porting_Notes
  
  Since, AFAICS, only the fonts KCM uses that functionality, it might be better to move/copy KFontDialog to the KCM, and maybe rename it; it'd be a helper class of sorts.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200309/08c8cc43/attachment.html>