<table><tr><td style="">ahmadsamir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27808">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27808#625052" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27808#625052</a>, <a href="https://phabricator.kde.org/p/meven/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@meven</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Porting with such feature regression is hard to justify.</p></div>
</blockquote>
<p>I honestly don't know how many users actually use that feature; if it's still widely used, then yeah, that would definitely be a feature regression.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Perhaps we should port KFontDialog (it is ~150 lines of cpp) to kwidgetsaddons instead, <tt style="background: #ebebeb; font-size: 13px;">KFontChooser</tt> is already there.<br />
Or better perhaps implement here a simple QDialog embedding <tt style="background: #ebebeb; font-size: 13px;">KFontChooser</tt> and providing equivalent features needed here that KFontDialog has.<br />
This is a typical work we did for KF5 <a href="https://community.kde.org/Frameworks/Porting_Notes" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Frameworks/Porting_Notes</a></p></blockquote>
<p>Since, AFAICS, only the fonts KCM uses that functionality, it might be better to move/copy KFontDialog to the KCM, and maybe rename it; it'd be a helper class of sorts.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27808">https://phabricator.kde.org/D27808</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Plasma, davidedmundson, broulik, ervin, meven<br /><strong>Cc: </strong>bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>