D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[David Redondo]

davidre added a comment.


  I want to echo the sentiment that Breeze should not gain more options and this instead be a new decoration. I see the issue with mdi windows having different titlebars because they are drawn by the QStyle but you add these options here you are only solving this problem for this particular instance if Breeze decorations and Breeze style is selected. This is no difference as before, there are many popular decorations and we can't add an option for every one of them so that the decorations are consistent.
  
  This is a fundamental limitation because mdi decorations are drawn by the QStyle. Maybe this is a problem to be solved somewhere else like in Qt. In Wayland there is a protocol t ask the server decorations so Qt could use that if available and only than fallback to the style. Or maybe we could do something in KStyle.
  
  > With regards to why not a separate theme, that was actually my original plan, but I wanted to use Breeze as the base. When I asked 3 years ago if there was an Aurorae theme for Breeze that I could edit I was told there was not and that it was just C++; is this still the case today? Can the Breeze theme be easily forked and redistributed in the GetHotNewStuff dialogue box? If so, how, and where to share? I also wanted to change the Application Style as well as the Window Decorations (i.e. the style of buttons to dock/undock and close etc. within applications with dockable panes). Can you easily fork, redistribute and download new Application Styles in the GetHotNewStuff dialogue box as well?
  
  If your goal is to have breeze with different button style I think sadly not. I am not that knowledgable what is possible or not with ghns but I think right now it is limited to aurorae. But you could always make a simple auorae theme that looks like breeze (I don't know how hard that is). But there are also popular 3rdparty decorations that are not distributed though GHNS. I keep seeing for example https://github.com/kupiqu/SierraBreezeEnhanced being a popular theme that is a fork of breeze from looking at the code.
  
  Sadly there is also no GHNS for QStyles as it suffers from the same problem that as far as I understand it doesn't support stuff that needs to be compiled and binary compatible to the users system.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: davidre, ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200309/ce7f147a/attachment-0001.html>