D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added a comment.


  In D9875#675101 <https://phabricator.kde.org/D9875#675101>, @mkoller wrote:
  
  > This patch breaks usage for git (and probably others):
  >  git first asks for a "Username for 'https:...." which leads to ksshaskpass open the input dialog but the typed-in user
  >  is no longer stored into the wallet!!
  >  (See case TypeClearText)
  >  This leads to git again and again ask for the Username on each invokation.
  >
  > Please ensure that even the Username is stored again _in the same folder_ in kwallet as before (e.g. below Passwords)
  >  otherwise it also breaks using existing passwords. E.g. reading
  >
  >   if (type != TypePassword) {
  >              QByteArray retrievedBytes;
  >              wallet->readEntry(identifier, retrievedBytes);
  >
  > is wrong (backwards incompatible).
  
  
  Can you make a patch?
  
  Having a quick look at the previous code, it seems like username and password shared the identifier, so they overwrote each other.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: fvogt, pali, lbeltrame
Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200613/c69f6cc8/attachment-0001.htm>