D9875: Extend parsing ssh prompt

[Martin Koller]

mkoller reopened this revision.
mkoller added a comment.
This revision is now accepted and ready to land.


  This patch breaks usage for git (and probably others):
  git first asks for a "Username for 'https:...." which leads to ksshaskpass open the input dialog but the typed-in user
  is no longer stored into the wallet!!
  (See case TypeClearText)
  This leads to git again and again ask for the Username on each invokation.
  
  Please ensure that even the Username is stored again _in the same folder_ in kwallet as before (e.g. below Passwords)
  otherwise it also breaks using existing passwords. E.g. reading 
   if (type != TypePassword) {
  
    QByteArray retrievedBytes;
    wallet->readEntry(identifier, retrievedBytes);
  
  is wrong (backwards incompatible).

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: fvogt, pali, lbeltrame
Cc: mkoller, lbeltrame, ngraham, fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200613/c5579d2d/attachment.htm>