D26665: Switch to KNSQuick for getting new wallpapers

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D26665#601713 <https://phabricator.kde.org/D26665#601713>, @IlyaBizyaev wrote:
  
  > What about the "Get New Plugins" button in the same dialog? It still uses the old style.
  >  Probably unrelated, but for me, both of these buttons fail to actually load anything, stuck connecting forever. I would blame all of my internet connections that I tried it with, but it does not happen in System Settings, so maybe there's some bug here.
  
  
  
  
    The reason that wasn't changed in this step is simple - because it isn't simple ;) You'll notice that the change here was very much a trivial swap. Changing the other KNS integration points out for the new one will be considerably more effort, hence it isn't happening just yet.
  
  > And also, looking at @victorr's screenshot, I see that the "Close" button has no label on it. I got same problem here as well.
  
  That really is a very strange error. Not sure why such a thing would fail. The code in question can be seen here: https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98 - However, the whole thing is also being discussed elsewhere, making this the wrong place. Would be good to get more eyes on the situation :) https://bugs.kde.org/show_bug.cgi?id=413434

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26665

To: leinir, mart, #plasma, ngraham
Cc: IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200128/a3e8011e/attachment-0001.html>