D26850: [SystemTray] Refresh icon in settings on update

[Konrad Materka]

kmaterka marked an inline comment as done.
kmaterka added inline comments.

INLINE COMMENTS

> broulik wrote in systemtraymodel.cpp:269
> Avoid `keys()` which creates a temporary list, instead use iterators
> 
>   const auto roleNames = sourceModel->roleNames();
>   for (auto it = roleNames.begin(), end = roleNames.end(); it != end; ++it) {
>       if (!m_roleNames.contains(it.key()) {
>           m_roleNames.insert(it.key(), it.value());
>       }
>   }

Done. Does it matter if I use Java-style iterator or STL-style? Documentation says that STL-style is slightly faster, but I like Java -style more. I checked plasma-workspace and both are used.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26850

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200123/8969eacf/attachment.html>