D26844: Warn user when changing selected user about potential data loss

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> accountinfo.cpp:108
> +    if (!m_infoToSave.isEmpty()) {
> +        if (KMessageBox::questionYesNo(this,i18n("<qt>You modified the current user, do want to save that change now ?</qt>"),QString(),KStandardGuiItem::save(),KStandardGuiItem::discard())==KMessageBox::Yes) save();
> +    }

1. Needs more whitespace around things
2. Change string to "Save changes to this user?"
3. What's this `<qt>` tag? Why is it needed?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26844

To: meven, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200122/066df1a1/attachment-0001.html>