<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26844">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26844#inline-151809">View Inline</a><span style="color: #4b4d51; font-weight: bold;">accountinfo.cpp:108</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_infoToSave</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">questionYesNo</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<qt>You modified the current user, do want to save that change now ?</qt>"</span><span class="p">),</span><span class="n">QString</span><span class="p">(),</span><span class="n">KStandardGuiItem</span><span style="color: #aa2211">::</span><span class="n">save</span><span class="p">(),</span><span class="n">KStandardGuiItem</span><span style="color: #aa2211">::</span><span class="n">discard</span><span class="p">())</span><span style="color: #aa2211">==</span><span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">Yes</span><span class="p">)</span> <span class="n">save</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ol class="remarkup-list">
<li class="remarkup-list-item">Needs more whitespace around things</li>
<li class="remarkup-list-item">Change string to "Save changes to this user?"</li>
<li class="remarkup-list-item">What's this <tt style="background: #ebebeb; font-size: 13px;"><qt></tt> tag? Why is it needed?</li>
</ol></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R128 User Manager</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26844">https://phabricator.kde.org/D26844</a></div></div><br /><div><strong>To: </strong>meven, ngraham, Plasma<br /><strong>Cc: </strong>plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>