D26504: [Panel Shadows] Port to KWindowSystem shadows API

David Edmundson noreply at phabricator.kde.org
Wed Jan 22 10:46:12 GMT 2020


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I love red!

INLINE COMMENTS

> panelshadows.cpp:185
>  
> +    KWindowShadow *&shadow = m_shadows[window];
>  

you can pass a parent here, then we don't need to clean up in the destructor

REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26504

To: zzag, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200122/662b2c2b/attachment-0001.html>


More information about the Plasma-devel mailing list