<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26504">View Revision</a></tr></table><br /><div><div><p>I love red!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26504#inline-151663">View Inline</a><span style="color: #4b4d51; font-weight: bold;">panelshadows.cpp:185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">m_emptyCornerPix</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">initEmptyPixmap</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QSize</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">))</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_emptyCornerLeftPix</span> <span style="color: #aa2211">=</span> <span class="n">initEmptyPixmap</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">elementSize</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"shadow-topleft"</span><span class="p">)).</span><span class="n">width</span><span class="p">(),</span> <span style="color: #601200">1</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_emptyCornerTopPix</span> <span style="color: #aa2211">=</span> <span class="n">initEmptyPixmap</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">elementSize</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"shadow-topleft"</span><span class="p">)).</span><span class="n">height</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_emptyCornerRightPix</span> <span style="color: #aa2211">=</span> <span class="n">initEmptyPixmap</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">elementSize</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"shadow-bottomright"</span><span class="p">)).</span><span class="n">width</span><span class="p">(),</span> <span style="color: #601200">1</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_emptyCornerBottomPix</span> <span style="color: #aa2211">=</span> <span class="n">initEmptyPixmap</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">elementSize</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"shadow-bottomright"</span><span class="p">)).</span><span class="n">height</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_emptyVerticalPix</span> <span style="color: #aa2211">=</span> <span class="n">initEmptyPixmap</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">elementSize</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"shadow-left"</span><span class="p">)).</span><span class="n">height</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_emptyHorizontalPix</span> <span style="color: #aa2211">=</span> <span class="n">initEmptyPixmap</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span class="n">q</span><span style="color: #aa2211">-></span><span class="n">elementSize</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"shadow-top"</span><span class="p">)).</span><span class="n">width</span><span class="p">(),</span> <span style="color: #601200">1</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">KWindowShadow</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*&</span></span><span class="bright"></span><span class="n"><span class="bright">shadow</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">m_shadows</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span class="n"><span class="bright">window</span></span><span class="bright"></span><span class="p"><span class="bright">]</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can pass a parent here, then we don't need to clean up in the destructor</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>port-to-shadows-api</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26504">https://phabricator.kde.org/D26504</a></div></div><br /><div><strong>To: </strong>zzag, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>