D26806: [Applets/Power Manager] Update layout based on T10470

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> BatteryItem.qml:150
> +
> +            property int _s: units.largeSpacing / 2
> +

can we use units.smallSpacing

If we invent our own margin policy everywhere by multiplying by random factors we're not going to have any consistency.

> BatteryItem.qml:152
> +
> +            Layout.minimumWidth: implicitWidth + batteryItemToolTip._s
> +            Layout.minimumHeight: implicitHeight + batteryItemToolTip._s * 2

you're using Layout. in a child of something that's not a layout

> BatteryItem.qml:162
> +            BatteryIcon {
> +                x: batteryItemToolTip._s * 2
> +                y: batteryItemToolTip._s

Setting X in a row is a bad idea, use a layout

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200121/b188a517/attachment-0001.html>