D26799: Apply KDE coding style, minor optimizations
Méven Car
noreply at phabricator.kde.org
Mon Jan 20 22:34:48 GMT 2020
meven added a comment.
Nice changes.
INLINE COMMENTS
> filteredfoldermodel.cpp:38
> +{
> +QStringList addTrailingSlashes(const QStringList &input)
> +{
space ? I am not sure.
> kcm.cpp:44
> {
> - QStringList defaultFolders()
> - {
> - return { QDir::homePath() };
> - }
> +inline QStringList defaultFolders()
> +{
space ?
> kcm.cpp:72
> + connect(m_filteredFolderModel, &FilteredFolderModel::folderAdded, this, [this]
> + { setNeedsSave(true); });
> + connect(m_filteredFolderModel, &FilteredFolderModel::folderRemoved, this, [this]
I did not know this formatting,, but I am not a specialist of kde policy.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26799
To: alex, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200120/3580f8f5/attachment-0001.html>
More information about the Plasma-devel
mailing list