D26799: Apply KDE coding style, minor optimizations
Alexander Lohnau
noreply at phabricator.kde.org
Mon Jan 20 20:09:27 GMT 2020
alex created this revision.
alex added reviewers: ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
The affected files have been reformatted following the KDE coding style (this makes up most of the changes).
kcm.cpp: The config.setFirstRun method calls have been simplified (line 103) and the defaultFolders function is now inline.
filterfoldermodel.cpp: Use const references for the mount points (folderDisplayName method, line 204), simplify if statement in shouldShowMountPoint (line 223) and remove unnecessary return in data method.
TEST PLAN
Should work as before
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26799
AFFECTED FILES
kcms/baloo/fileexcludefilters.cpp
kcms/baloo/filteredfoldermodel.cpp
kcms/baloo/kcm.cpp
To: alex, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200120/cfd72c09/attachment.html>
More information about the Plasma-devel
mailing list