D26729: do not disable getifaddrs use because of sa_len availablility

Harald Sitter noreply at phabricator.kde.org
Fri Jan 17 15:24:45 GMT 2020


sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this fixes ipv6 support in nic listing. well, kinda.
  
  the getifaddrs branch is the only one supporting ipv6 properly
  so it seems silly to use the ioctl branch just because sa_len
  is not available.
  simply wrap around getnameinfo and either use sa_len or
  determine the length based on the socket family (as seen on the
  getifaddrs manpage). this way the branch compiles fine without
  sa_len and is fine to use by just about all glibc systems thus
  giving us ipv6 support on just about every glib system.
  
  BUG: 313892
  FIXED-IN: 5.18.0

TEST PLAN
  built on neon. shows ipv6 addresses

REPOSITORY
  R102 KInfoCenter

BRANCH
  ipv6

REVISION DETAIL
  https://phabricator.kde.org/D26729

AFFECTED FILES
  Modules/nics/nic.cpp

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200117/0c82beb2/attachment.html>


More information about the Plasma-devel mailing list