<table><tr><td style="">sitter created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26729">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>this fixes ipv6 support in nic listing. well, kinda.</p>
<p>the getifaddrs branch is the only one supporting ipv6 properly<br />
so it seems silly to use the ioctl branch just because sa_len<br />
is not available.<br />
simply wrap around getnameinfo and either use sa_len or<br />
determine the length based on the socket family (as seen on the<br />
getifaddrs manpage). this way the branch compiles fine without<br />
sa_len and is fine to use by just about all glibc systems thus<br />
giving us ipv6 support on just about every glib system.</p>
<p>BUG: 313892<br />
FIXED-IN: 5.18.0</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>built on neon. shows ipv6 addresses</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>BRANCH</strong><div><div>ipv6</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26729">https://phabricator.kde.org/D26729</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>Modules/nics/nic.cpp</div></div></div><br /><div><strong>To: </strong>sitter<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>