D26689: [MPRIS Data Engine] Refactor to reduce code duplication

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `addPlayer` and `playerUpdated` effectively do the same, so merge the two implementations.
  Also simplify nesting in `setPlayerActive`

TEST PLAN
  Still behaves as before:
  
  - It never switches away from a playing player when another starts playing
  - It switches to a playing player if there was none before
  - When current player gets paused, it switches to another playing one, if any, or a paused one, if any, or a stopped one, if any
  - Closing a player, switches to another play one, if any, or a paused one, if any, or a stopped one, if any

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26689

AFFECTED FILES
  dataengines/mpris2/multiplexer.cpp
  dataengines/mpris2/multiplexer.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200115/7f1012d2/attachment-0001.html>