D26681: [TabBox] Thumbnail Grid window switcher

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Jan 15 14:08:44 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> main.qml:1
> +/********************************************************************
> + KWin - the KDE window manager

Bad file permissions. Needs to be 644.

> main.qml:74-76
> +                var c = Math.min(thumbnailGridView.count, maxGridColumnsByWidth);
> +
> +                var residue = thumbnailGridView.count % c;

You could use `const` here

  const c = ...
  
  const residue = ...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200115/6e67623e/attachment.html>


More information about the Plasma-devel mailing list