D26680: [kcms/feedback] Implement setRepresentsDefaults

David Edmundson noreply at phabricator.kde.org
Wed Jan 15 11:42:18 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> meven wrote in feedback.cpp:43
> nitpick, You could move this to `Feedback::setPlasmaFeedbackLevel` as well.
> 1 saves a connect, 
> 2 make setRepresesentsDefault and setNeedsSave close in the file

sorry I missed your comment.

I'll make this change.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26680

To: davidedmundson, #plasma, ngraham
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200115/94d1599f/attachment.html>


More information about the Plasma-devel mailing list