D26658: WIP: fix(kwayland): stall tablet config change

Roman Gilg noreply at phabricator.kde.org
Tue Jan 14 12:10:26 GMT 2020


romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  It seems only checking on no outputs initializing and signals being unblocked
  is not enough when cancelling a config change on tablet mode information
  change.
  
  There can be a race between the interface being announced and tablet mode
  information being changed before any output device received. In this case a
  config change is applied with no output management yet being available.
  
  Looking at the code though this seems to only be possible if the interfaces
  announced event is received before the output maangement interface announced
  event. This is not what should happen.

TEST PLAN
  Starts without seg fault on output management object in applyConfig.

REPOSITORY
  R110 KScreen Library

BRANCH
  tablet-fix

REVISION DETAIL
  https://phabricator.kde.org/D26658

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200114/73aafecd/attachment.html>


More information about the Plasma-devel mailing list