D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

Méven Car noreply at phabricator.kde.org
Sun Jan 12 10:55:06 GMT 2020


meven added a comment.


  In D26582#592266 <https://phabricator.kde.org/D26582#592266>, @aleksejshilin wrote:
  
  > In D26582#591959 <https://phabricator.kde.org/D26582#591959>, @meven wrote:
  >
  > > Well there was already KRun::setRunExecutables :)
  >
  >
  > I've already talked about it in my previous message:
  >
  > In D26582#591952 <https://phabricator.kde.org/D26582#591952>, @aleksejshilin wrote:
  >
  > > KRun currently doesn't seem to have a way to force opening of executables - one can only prohibit running them with setRunExecutables(), in which case an error message is displayed. That's why I decided to go the way it is now.
  >
  >
  > For example:
  >
  > 1. Install Okteta.
  > 2. Associate application/x-sharedlib mime type with Okteta.
  > 3. Open a shared library with Okteta.
  > 4. Try to open it again from 'Recent Documents'.
  >
  >   Instead of opening the file in Okteta, it'll show a message box saying that the executable file won't be started for security reasons.
  >
  >   I admit that it's not a likely scenario though, so let's see what others have to say.
  
  
  Thanks for testing this. There is a different treatment with nativeBinary in KRun,
  We may want to change KRun::runUrl when a native binary is to be run but with runExecutable is false, around line 400:
  
    } else if (isNativeBinary) {
        // Show warning for executables that aren't scripts
        noRun = true;
    }
  
  I guess in this case with could check for mime-type associated apps like oketa can be with any binary file, perhaps adding a flag.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200112/dbdb97a4/attachment.html>


More information about the Plasma-devel mailing list