D26545: WIP: [SystemTray] Set maximum size to block tiling

[Konrad Materka]

kmaterka added a comment.


  In D26545#590861 <https://phabricator.kde.org/D26545#590861>, @ngraham wrote:
  
  > FWIW it is possible to restore the original size by using the same tiling shortcut again.
  
  
  Oh, I tested this on multi-screen setup, but it is working indeed if:
  
  - I use shortcut few more times to iterate all screens
  - I did not click to hide popup. If it is hidden, it won't restore.
  
  > Still a bug that should be fixed of course, and this is the way that Kicker and Kickoff and others prevent tiling. For now, it seems sane enough to do the same thing here too. BTW, the change for the clock applet doesn't work for me; maybe that should be left out of the patch for now?
  
  It is not blocking tiling for digital clock because minimum size != preferred size for whatever reasons. As result, it is not possible to set maximum size equal to minimum size. But this change helps, because on next show (if you hide calendar and click again) it should show with correct size.
  
  > I agree that in the long term, it might make sense to do this prevent tiling using a more elegant method so we don't need to implement his hack in every applet with an expanded representation.
  
  That was my point - I'm sure it is possible somehow, Qt (?) is doing this automatically when maximum size = minimum size.
  
  For System Tray, setting the maximum size for ExpandedRepresentation is a good idea, but some plasmoids can't be fixed this way. For example: Clipboard. Usually it is part of the system tray, but:
  
  - it can be added on the desktop. Full representation is the default, so we can't set maximum size, users can set any size they want
  - on the panel - compact representation is used (icon), full representation is encapsulated in fixed size PlasmaCore.Dialog. Nothig we can do to prevent tiling.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26545

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200109/ff682c04/attachment.html>