D26523: KCM kded, fix immutability and reset/apply/default button state

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> kcmkded.cpp:319
> +		if (_lvStartup->topLevelItem( i )->flags() & Qt::ItemIsEnabled) {
> +			_lvStartup->topLevelItem( i )->setCheckState( StartupUse, Qt::Checked );
> +		}

I know you didn't write that line, but it looks like this contradicts the code in save() or I'm confused? (the code is not easy)

It looks like save ignore the state of the checkbox if X-KDE-Kded-autoload is false in the plugin metadata.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26523

To: bport, ervin, meven, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200108/71769a93/attachment.html>