<table><tr><td style="">ervin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26523">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26523#inline-149465">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcmkded.cpp:319</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">_lvStartup</span><span style="color: #aa2211">-></span><span class="n">topLevelItem</span><span class="p">(</span> <span class="n">i</span> <span class="p">)</span><span style="color: #aa2211">-></span><span class="n">flags</span><span class="p">()</span> <span style="color: #aa2211">&</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">ItemIsEnabled</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">_lvStartup</span><span style="color: #aa2211">-></span><span class="n">topLevelItem</span><span class="p">(</span> <span class="n">i</span> <span class="p">)</span><span style="color: #aa2211">-></span><span class="n">setCheckState</span><span class="p">(</span> <span class="n">StartupUse</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Checked</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I know you didn't write that line, but it looks like this contradicts the code in save() or I'm confused? (the code is not easy)</p>
<p style="padding: 0; margin: 8px;">It looks like save ignore the state of the checkbox if X-KDE-Kded-autoload is false in the plugin metadata.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26523">https://phabricator.kde.org/D26523</a></div></div><br /><div><strong>To: </strong>bport, ervin, meven, crossi<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>