D26271: [Applet]Update layout based on T10470
George Vogiatzis
noreply at phabricator.kde.org
Mon Jan 6 09:37:07 GMT 2020
gvgeo updated this revision to Diff 72854.
gvgeo added a comment.
leanup
Remove separation lines
Fix 2 bugs
Full Name display when a port name sub-strings are same.
Requested changes
Issues:
1. Check comment at the bottom of main.qml in D26256 <https://phabricator.kde.org/D26256>
These two strange margins (including defaultButton in this patch), are required to vertical align the icons in their center, and the texts with the slider.
2. Setting preferredHeight in fullRepresentation makes widget on desktop to load with size >= preferredHeight on boot.
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26271?vs=72750&id=72854
BRANCH
layout (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26271
AFFECTED FILES
applet/contents/ui/DeviceListItem.qml
applet/contents/ui/ListItemBase.qml
applet/contents/ui/StreamListItem.qml
applet/contents/ui/main.qml
To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200106/6c0ceba3/attachment.html>
More information about the Plasma-devel
mailing list