D26354: Introduce ActionRow widget

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ActionRow.qml:51
> +
> +    height: 64
> +

Make this a multiple of GridUnit

> ActionRow.qml:144
> +                anchors.left: parent.left
> +                anchors.leftMargin: 20
> +                anchors.verticalCenter: parent.verticalCenter

use a multiple of largeSpacing or smallSpacing or even gridUnit

> ActionRow.qml:147
> +                Kirigami.Icon {
> +                    width: 22
> +                    height: 22

smallMedium size

> ActionRow.qml:151
> +                    source: leftAction.icon.name
> +                    Kirigami.Theme.textColor: drag.translation.x > root.width*(1/4) ? defaultFg(leftAction.Kirigami.SwipeAction.foregroundColor) : "white"
> +                    anchors.horizontalCenter: parent.horizontalCenter

don't hardcode colors

> ActionRow.qml:156
> +                    anchors.horizontalCenter: parent.horizontalCenter
> +                    color: drag.translation.x > root.width*(1/4) ? defaultFg(leftAction.Kirigami.SwipeAction.foregroundColor) : "white"
> +                    Behavior on color {

ditto

> ActionRow.qml:187
> +                anchors.right: parent.right
> +                anchors.rightMargin: 20
> +                anchors.verticalCenter: parent.verticalCenter

ditto

> ActionRow.qml:190
> +                Kirigami.Icon {
> +                    width: 22
> +                    height: 22

ditto

> ActionRow.qml:194
> +                    visible: rightAction.icon.name != ""
> +                    Kirigami.Theme.textColor: drag.translation.x > root.width*(1/4) ? defaultFg(leftAction.Kirigami.SwipeAction.foregroundColor) : "white"
> +                    anchors.horizontalCenter: parent.horizontalCenter

ditto

> ActionRow.qml:199
> +                    anchors.horizontalCenter: parent.horizontalCenter
> +                    color: drag.translation.x < -root.width*(1/4) ? defaultFg(rightAction.Kirigami.SwipeAction.foregroundColor) : "white"
> +                    Behavior on color {

ditto

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26354

To: cblack, #vdg, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200101/ec0316e0/attachment-0001.html>