<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26354">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148396">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">height:</span> <span style="color: #601200">64</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Make this a multiple of GridUnit</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148397">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:144</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.left:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">left</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.leftMargin:</span> <span style="color: #601200">20</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.verticalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">verticalCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use a multiple of largeSpacing or smallSpacing or even gridUnit</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148398">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:147</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Icon</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #601200">22</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">height:</span> <span style="color: #601200">22</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">smallMedium size</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148400">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:151</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">source:</span> <span style="color: #004012">leftAction</span><span class="p">.</span><span style="color: #004012">icon</span><span class="p">.</span><span style="color: #004012">name</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Kirigami.Theme.textColor:</span> <span style="color: #004012">drag</span><span class="p">.</span><span style="color: #004012">translation</span><span class="p">.</span><span style="color: #004012">x</span> <span style="color: #aa2211">></span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">*</span><span class="p">(</span><span style="color: #601200">1</span><span style="color: #aa2211">/</span><span style="color: #601200">4</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">defaultFg</span><span class="p">(</span><span style="color: #004012">leftAction</span><span class="p">.</span><span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">SwipeAction</span><span class="p">.</span><span style="color: #004012">foregroundColor</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"white"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.horizontalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">horizontalCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">don't hardcode colors</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148401">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:156</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.horizontalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">horizontalCenter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">drag</span><span class="p">.</span><span style="color: #004012">translation</span><span class="p">.</span><span style="color: #004012">x</span> <span style="color: #aa2211">></span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">*</span><span class="p">(</span><span style="color: #601200">1</span><span style="color: #aa2211">/</span><span style="color: #601200">4</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">defaultFg</span><span class="p">(</span><span style="color: #004012">leftAction</span><span class="p">.</span><span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">SwipeAction</span><span class="p">.</span><span style="color: #004012">foregroundColor</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"white"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Behavior</span> <span style="color: #004012">on</span> <span style="color: #004012">color</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148402">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:187</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.right:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">right</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.rightMargin:</span> <span style="color: #601200">20</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.verticalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">verticalCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148399">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:190</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Icon</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #601200">22</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">height:</span> <span style="color: #601200">22</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148403">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:194</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">rightAction</span><span class="p">.</span><span style="color: #004012">icon</span><span class="p">.</span><span style="color: #004012">name</span> <span style="color: #aa2211">!=</span> <span style="color: #766510">""</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Kirigami.Theme.textColor:</span> <span style="color: #004012">drag</span><span class="p">.</span><span style="color: #004012">translation</span><span class="p">.</span><span style="color: #004012">x</span> <span style="color: #aa2211">></span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">*</span><span class="p">(</span><span style="color: #601200">1</span><span style="color: #aa2211">/</span><span style="color: #601200">4</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">defaultFg</span><span class="p">(</span><span style="color: #004012">leftAction</span><span class="p">.</span><span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">SwipeAction</span><span class="p">.</span><span style="color: #004012">foregroundColor</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"white"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.horizontalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">horizontalCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26354#inline-148404">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionRow.qml:199</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.horizontalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">horizontalCenter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">drag</span><span class="p">.</span><span style="color: #004012">translation</span><span class="p">.</span><span style="color: #004012">x</span> <span style="color: #aa2211"><</span> <span style="color: #aa2211">-</span><span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">width</span><span style="color: #aa2211">*</span><span class="p">(</span><span style="color: #601200">1</span><span style="color: #aa2211">/</span><span style="color: #601200">4</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">defaultFg</span><span class="p">(</span><span style="color: #004012">rightAction</span><span class="p">.</span><span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">SwipeAction</span><span class="p">.</span><span style="color: #004012">foregroundColor</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"white"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Behavior</span> <span style="color: #004012">on</span> <span style="color: #004012">color</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26354">https://phabricator.kde.org/D26354</a></div></div><br /><div><strong>To: </strong>cblack, VDG, Kirigami<br /><strong>Cc: </strong>ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart, hein<br /></div>